Re: [PATCH 2/4] KVM: stats: Use binary stats descriptors for debugfs interface

On 14/06/21 04:53, Jing Zhang wrote:

+	STATS_DESC_ICOUNTER_RONLY(VM, lpages),
+	STATS_DESC_ICOUNTER_RONLY(VM, nx_lpage_splits),
 	STATS_DESC_ICOUNTER(VM, max_mmu_page_hash_collisions)

I think we're now adding too many macros.

max_mmu_page_hash_collisions is the only remaining instant counter that 
is not read-only.  In fact, in the statsfs prototype we made all instant 
counters read-only.

You could add a third type in addition to instant and cumulative, let's 
call it "peak".  This essentially corresponds to the "max" aggregation 
function in the statsfs prototype.  Then instant counters would be read 
only, while cumulative and peak would be read-write.

Paolo