Thread (3 messages) 3 messages, 3 authors, 2021-06-03

Re: [PATCH v2] PCI: ftpci100: rename macro name collision

From: Linus Walleij <hidden>
Date: 2021-05-17 23:57:35
Also in: linux-pci

On Tue, May 18, 2021 at 1:41 AM Randy Dunlap [off-list ref] wrote:
PCI_IOSIZE is defined in mach-loongson64/spaces.h, so change the name
of the PCI_* macros in pci-ftpci100.c to use FTPCI_* so that they are
more localized and won't conflict with other drivers or arches.

../drivers/pci/controller/pci-ftpci100.c:37: warning: "PCI_IOSIZE" redefined
   37 | #define PCI_IOSIZE 0x00
      |
In file included from ../arch/mips/include/asm/addrspace.h:13,
...              from ../drivers/pci/controller/pci-ftpci100.c:15:
arch/mips/include/asm/mach-loongson64/spaces.h:11: note: this is the location of the previous definition
   11 | #define PCI_IOSIZE SZ_16M

Signed-off-by: Randy Dunlap <redacted>
Reported-by: kernel test robot <redacted>
Suggested-by: Linus Walleij <redacted>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Linus Walleij <redacted>
Cc: Krzysztof Wilczyński <redacted>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
---
v2: prefix PCI_ macro names with "FT", thus use FTPCI_ for these macro names.
    (suggested by Linus Walleij)
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help