Re: [PATCH net-next v1 2/9] net: dsa: tag_ar9331: detect IGMP and MLD packets
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-04-03 14:50:05
Also in:
lkml, netdev
quoted hunk ↗ jump to hunk
@@ -31,6 +96,13 @@ static struct sk_buff *ar9331_tag_xmit(struct sk_buff *skb, __le16 *phdr; u16 hdr; + if (dp->stp_state == BR_STATE_BLOCKING) { + /* TODO: should we reflect it in the stats? */ + netdev_warn_once(dev, "%s:%i dropping blocking packet\n", + __func__, __LINE__); + return NULL; + } + phdr = skb_push(skb, AR9331_HDR_LEN); hdr = FIELD_PREP(AR9331_HDR_VERSION_MASK, AR9331_HDR_VERSION);
Hi Oleksij This change does not seem to fit with what this patch is doing. I also think it is wrong. You still need BPDU to pass through a blocked port, otherwise spanning tree protocol will be unstable. Andrew