Re: [PATCH 1/2] drm/ingenic: Switch IPU plane to type OVERLAY
From: Simon Ser <hidden>
Date: 2021-03-30 07:24:24
Also in:
dri-devel, lkml, stable
It should have been an OVERLAY from the beginning. The documentation stipulates that there should be an unique PRIMARY plane per CRTC.
Thanks for the quick patch! One comment below…
quoted hunk ↗ jump to hunk
Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") Cc: <redacted> # 5.8+ Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 11 +++++------ drivers/gpu/drm/ingenic/ingenic-ipu.c | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-)diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index 29742ec5ab95..09225b770bb8 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c@@ -419,7 +419,7 @@ static void ingenic_drm_plane_enable(struct ingenic_drm *priv, unsigned int en_bit; if (priv->soc_info->has_osd) { - if (plane->type == DRM_PLANE_TYPE_PRIMARY) + if (plane != &priv->f0)
I don't know about this driver but… is this really the same as the previous condition? The previous condition would match two planes, this one seems to match only a single plane. What am I missing?