Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII
From: Lars Povlsen <hidden>
Date: 2021-02-10 13:47:11
Also in:
linux-arm-kernel, linux-gpio, lkml
Geert Uytterhoeven writes:
quoted hunk ↗ jump to hunk
the Microsemi/Microchip Serial GPIO device is present only Microsemi VCore III and Microchip Sparx5 SoCs. Hence add a dependency on ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this driver when configuring a kernel without support for these SoCs. Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/pinctrl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig@@ -353,8 +353,8 @@ config PINCTRL_OCELOT config PINCTRL_MICROCHIP_SGPIO bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" - depends on OF - depends on HAS_IOMEM + depends on OF && HAS_IOMEM + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST select GPIOLIB select GPIOLIB_IRQCHIP select GENERIC_PINCONF
Geert, Thank you for your patch. Unfortunately, it makes it impossible to use the driver across PCIe - which is a specifically desired configuration. Could you add CONFIG_PCI to the || chain? Cheers, -- Lars Povlsen, Microchip