Re: [PATCH] MIPS: Make definitions of MIPSInst_FMA_{FUNC,FMTM} consistent with MIPS64 manual
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-01-22 12:06:28
Also in:
lkml
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-01-22 12:06:28
Also in:
lkml
On Fri, Jan 22, 2021 at 03:53:18PM +0800, Tiezhu Yang wrote:
The kernel definitions of MIPSInst_FMA_FUNC and MIPSInst_FMA_FFMT are not consistent with MADD.fmt, NMADD.fmt and NMSUB.fmt in the MIPS64 manual [1], the field func is bit 5..3 and fmt is bit 2..0, fix them. Otherwise there exists error when add new instruction simulation. [1] https://www.mips.com/?do-download=the-mips64-instruction-set-v6-06 Reported-by: Ming Wang <redacted> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- arch/mips/include/asm/inst.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]