Re: [PATCH] mips: cacheinfo: Remove unnecessary increment of level
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-01-18 09:25:06
Also in:
lkml
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-01-18 09:25:06
Also in:
lkml
On Sat, Jan 16, 2021 at 02:10:00PM +0530, Souptick Joarder wrote:
kernel test robot throws below warning -> arch/mips/kernel/cacheinfo.c:112:3: warning: Variable 'level' is modified but its new value is never used. [unreadVariable] Remove unnecessary increment of level at the end. Reported-by: kernel test robot <redacted> Signed-off-by: Souptick Joarder <redacted> --- arch/mips/kernel/cacheinfo.c | 1 - 1 file changed, 1 deletion(-)diff --git a/arch/mips/kernel/cacheinfo.c b/arch/mips/kernel/cacheinfo.c index 5f9d0eb..c858ae3 100644 --- a/arch/mips/kernel/cacheinfo.c +++ b/arch/mips/kernel/cacheinfo.c@@ -109,7 +109,6 @@ static int __populate_cache_leaves(unsigned int cpu) if (c->tcache.waysize) { populate_cache(tcache, this_leaf, level, CACHE_TYPE_UNIFIED); - level++;
please remove the no longer needed braces, too. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]