Thread (4 messages) 4 messages, 4 authors, 2021-01-16

RE: [PATCH] dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings

From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: 2021-01-16 20:30:12
Also in: linux-devicetree, lkml

(sorry for only seeing this late)

[...]
+maintainers:
+  - John Crispin [off-list ref]
personally I think we should get at least John's Acked-by but I don't
know if there's any rule for adding a dt-binding for some other
maintainer

[...]
+required:
+  - compatible
+  - reg
based on "DOs and DON’Ts for designing and writing Devicetree bindings"
from [0] I think this is incomplete
As far as I know CGU contains some PLLs. These PLLs need at least one
input: the main XTAL which is found on the board

Also the Lantiq code does not use the common clock framework yet. Once
that's used we also need #clock-cells = <1>. I don't know if that
should be added already (or not).
+examples:
+  - |
+    cgu@103000 {
this should be clock-controller@...


Best regards,
Martin


[0] https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-bindings.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help