Re: [PATCH v2] MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-01-13 10:45:05
Also in:
lkml
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: 2021-01-13 10:45:05
Also in:
lkml
On Mon, Jan 11, 2021 at 05:27:25AM -0800, menglong8.dong@gmail.com wrote:
From: Menglong Dong <redacted>
The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0'
can't be true.
Fix this by change the type of 'r' and 'i' from 'unsigned int'
to 'int'. As 'i' won't be negative, this change works.
Fixes: 99fbc70f8547 ("MIPS: Octeon: irq: Alloc desc before configuring IRQ")
Signed-off-by: Menglong Dong <redacted>
Reviewed-by: Alexander Sverdlin <redacted>
---
v2:
- change 'Fixes' from 64b139f97c01 to 99fbc70f8547
---
arch/mips/cavium-octeon/octeon-irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]