Thread (3 messages) 3 messages, 2 authors, 2020-02-24

Re: [PATCH] mm/vma: Append unlikely() while testing VMA access permissions

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2020-02-24 10:10:07
Also in: linux-m68k, linux-mm, lkml

Hi Anshuman,

Thanks for your patch!

On Mon, Feb 24, 2020 at 7:22 AM Anshuman Khandual
[off-list ref] wrote:
It is unlikely that an inaccessible VMA without required permission flags
will get a page fault. Hence lets just append unlikely() directive to such
Why? Isn't it the idea that you get a page fault when the page is not
accessible?
checks in order to improve performance while also standardizing it across
various platforms.
Does it make a difference to add these? Have you benchmarked this?
https://lwn.net/Articles/420019/

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help