[PATCH v3 net-next 15/15] net: sgi: ioc3-eth: no need to stop queue set_multicast_list
From: Thomas Bogendoerfer <hidden>
Date: 2019-08-30 09:26:24
Also in:
lkml, netdev
Subsystem:
ioc3 ethernet driver, networking drivers, the rest · Maintainers:
Thomas Bogendoerfer, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
netif_stop_queue()/netif_wake_qeue() aren't needed for changing multicast filters. Signed-off-by: Thomas Bogendoerfer <redacted> --- drivers/net/ethernet/sgi/ioc3-eth.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c
index 963ed0f9787c..deb636d653f3 100644
--- a/drivers/net/ethernet/sgi/ioc3-eth.c
+++ b/drivers/net/ethernet/sgi/ioc3-eth.c@@ -1627,8 +1627,6 @@ static void ioc3_set_multicast_list(struct net_device *dev) struct netdev_hw_addr *ha; u64 ehar = 0; - netif_stop_queue(dev); /* Lock out others. */ - spin_lock_irq(&ip->ioc3_lock); if (dev->flags & IFF_PROMISC) { /* Set promiscuous. */
@@ -1660,8 +1658,6 @@ static void ioc3_set_multicast_list(struct net_device *dev) } spin_unlock_irq(&ip->ioc3_lock); - - netif_wake_queue(dev); /* Let us get going again. */ } module_pci_driver(ioc3_driver);
--
2.13.7