Re: [PATCH v2 net-next 05/15] net: sgi: ioc3-eth: allocate space for desc rings only once
From: Thomas Bogendoerfer <hidden>
Date: 2019-08-30 08:09:30
Also in:
lkml, netdev
From: Thomas Bogendoerfer <hidden>
Date: 2019-08-30 08:09:30
Also in:
lkml, netdev
On Thu, 29 Aug 2019 15:05:04 -0700 Jakub Kicinski [off-list ref] wrote:
On Fri, 30 Aug 2019 00:00:58 +0200, Thomas Bogendoerfer wrote:
quoted
Out of curiosity does kcalloc/kmalloc_array give me the same guarantees about alignment ? rx ring needs to be 4KB aligned, tx ring 16KB aligned.I don't think so, actually, I was mostly worried you are passing address from get_page() into kfree() here ;) But patch 11 cures that, so that's good, too.
I realized that after sending my last mail. I'll fix that in v3 even it's just a transient bug. Thomas. -- SUSE Software Solutions Germany GmbH HRB 247165 (AG München) Geschäftsführer: Felix Imendörffer