Thread (1 message) 1 message, 1 author, 2018-03-16
STALE2991d REVIEWED: 1 (0M)

[PATCH 4.9 19/86] MIPS: OCTEON: irq: Check for null return on kzalloc allocation

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2018-03-16 15:22:42
Also in: lkml, stable

4.9-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Colin Ian King <redacted>

commit 902f4d067a50ccf645a58dd5fb1d113b6e0f9b5b upstream.

The allocation of host_data is not null checked, leading to a null
pointer dereference if the allocation fails. Fix this by adding a null
check and return with -ENOMEM.

Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
Signed-off-by: Colin Ian King <redacted>
Acked-by: David Daney <redacted>
Cc: Ralf Baechle <redacted>
Cc: "Steven J. Hill" <redacted>
Cc: linux-mips@linux-mips.org
Cc: <redacted> # 4.0+
Patchwork: https://patchwork.linux-mips.org/patch/18658/
Signed-off-by: James Hogan <jhogan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 arch/mips/cavium-octeon/octeon-irq.c |    2 ++
 1 file changed, 2 insertions(+)
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -2277,6 +2277,8 @@ static int __init octeon_irq_init_cib(st
 	}
 
 	host_data = kzalloc(sizeof(*host_data), GFP_KERNEL);
+	if (!host_data)
+		return -ENOMEM;
 	raw_spin_lock_init(&host_data->lock);
 
 	addr = of_get_address(ciu_node, 0, NULL, NULL);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help