RE: [PATCH 1/2] dt-bindings: Document mti,mips-cpc binding

From: Rob Herring [robh@kernel.org]
Sent: Saturday, December 16, 2017 7:26 PM
To: Aleksandar Markovic
Subject: Re: [PATCH 1/2] dt-bindings: Document mti,mips-cpc binding

On Fri, Dec 15, 2017 at 05:51:59PM +0100, Aleksandar Markovic wrote:

quoted

From: Paul Burton <redacted>

Document a binding for the MIPS Cluster Power Controller (CPC) which
simply allows the device tree to specify where the CPC registers should
be mapped.

Signed-off-by: Paul Burton <redacted>
Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
---
 Documentation/devicetree/bindings/misc/mti,mips-cpc.txt | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/mti,mips-cpc.txt

...

quoted

+++ b/Documentation/devicetree/bindings/misc/mti,mips-cpc.txt

@@ -0,0 +1,8 @@
+Binding for MIPS Cluster Power Controller (CPC).
+
+This binding allows a system to specify where the CPC registers should be
+mapped using device tree.

Not really where you map registers, but where they are located.

This will be corrected in the next version.

quoted

+
+Required properties:
+compatible : Should be "mti,mips-cpc".

Only one version of the block?

I am not clear what you mean by "version of the block". I you meant
number of allowed values for *compatible* property, yes, we want and
need just one such value (string).

quoted

+regs: Should describe the address & size of the CPC register region.
--

From alexandre.belloni@free-electrons.com Mon Dec 18 17:09:21 2017
Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 18 Dec 2017 17:09:28 +0100 (CET)
Received: from mail.free-electrons.com ([62.4.15.54]:49976 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK)
        by eddie.linux-mips.org with ESMTP id S23994630AbdLRQJUSAIPE (ORCPT
        <rfc822;linux-mips@linux-mips.org>); Mon, 18 Dec 2017 17:09:20 +0100
Received: by mail.free-electrons.com (Postfix, from userid 110)
        id B90C8203B5; Mon, 18 Dec 2017 17:09:09 +0100 (CET)
Received: from localhost (unknown [88.191.26.124])
        by mail.free-electrons.com (Postfix) with ESMTPSA id 8A2B72037A;
        Mon, 18 Dec 2017 17:08:59 +0100 (CET)
Date:   Mon, 18 Dec 2017 17:09:00 +0100
From:   Alexandre Belloni <redacted>
To:     Philippe Ombredanne <redacted>
Cc:     Linus Walleij <redacted>,
        Ralf Baechle [off-list ref],
        Linux MIPS [off-list ref],
        "linux-kernel@vger.kernel.org" [off-list ref],
        linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 05/13] pinctrl: Add Microsemi Ocelot SoC driver
Message-ID: [ref]
References: [ref]
 [ref]
 [ref]
 [ref]
 [ref]
 [ref]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: [ref]
User-Agent: Mutt/1.9.1 (2017-09-22)
Return-Path: [off-list ref]
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 61515
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: alexandre.belloni@free-electrons.com
Precedence: bulk
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
List-software: Ecartis version 1.0.0
List-Id: linux-mips <linux-mips.eddie.linux-mips.org>
X-List-ID: linux-mips <linux-mips.eddie.linux-mips.org>
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
X-list: linux-mips
Content-Length: 1260
Lines: 41

On 15/12/2017 at 08:59:15 +0100, Philippe Ombredanne wrote:

Alexandre, Linux

On Fri, Dec 15, 2017 at 12:53 AM, Linus Walleij
[off-list ref] wrote:

quoted

On Wed, Dec 13, 2017 at 10:23 AM, Philippe Ombredanne
[off-list ref] wrote:

quoted

On Wed, Dec 13, 2017 at 9:15 AM, Linus Walleij [off-list ref] wrote:

quoted

quoted

+// SPDX-License-Identifier: (GPL-2.0 OR MIT)

Wow never saw that before. OK I guess.

That's the new thing. Less legalese boilerplate, and more code for the
better IMHO.

You can check the doc patches from Thomas for details [1]

[1] https://lkml.org/lkml/2017/12/4/934

Yeah I'm aware of this part, but I didn't see that combined license
before.

What is the reason for not just using GPL 2 here?

Linus,
That'a a question for Alexandre that submitted this patch in the first
place, not me.

Alexandre?

I'm not the one taking that decision and I don't think this choice has a
particular issue (we use the same one for device trees).

I guess the idea behind it is to be able to reuse the same code in other
non-GPL projects.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com