Re: [PATCH v3] clk: let clk_disable() return immediately if clk is NULL
From: Masahiro Yamada <hidden>
Date: 2016-09-16 07:45:31
Also in:
linux-arm-kernel, linux-clk, lkml
From: Masahiro Yamada <hidden>
Date: 2016-09-16 07:45:31
Also in:
linux-arm-kernel, linux-clk, lkml
Hi Stephen, Michael, 2016-08-26 0:27 GMT+09:00 Florian Fainelli [off-list ref]:
On 08/24/2016 10:26 AM, Masahiro Yamada wrote:quoted
Many of clk_disable() implementations just return for NULL pointer, but this check is missing from some. Let's make it tree-wide consistent. It will allow clock consumers to call clk_disable() without NULL pointer check. Signed-off-by: Masahiro Yamada <redacted> Acked-by: Greg Ungerer <redacted> Acked-by: Wan Zongshun <redacted> --- I came back after a long pause. You can see the discussion about the previous version: https://www.linux-mips.org/archives/linux-mips/2016-04/msg00063.html Changes in v3: - Return only when clk is NULL. Do not take care of error pointer. Changes in v2: - Rebase on Linux 4.6-rc1 arch/arm/mach-mmp/clock.c | 3 +++ arch/arm/mach-w90x900/clock.c | 3 +++ arch/blackfin/mach-bf609/clock.c | 3 +++ arch/m68k/coldfire/clk.c | 4 ++++ arch/mips/bcm63xx/clk.c | 3 +++
Gentle ping... If you are not keen on this, shall I split it per-arch and send to each arch subsystem? -- Best Regards Masahiro Yamada