Thread (6 messages) 6 messages, 2 authors, 2016-07-22

Re: [PATCH 2/3] MIPS: Don't register r4k sched clock when CPUFREQ enabled

From: Huacai Chen <hidden>
Date: 2016-07-22 03:42:56
Also in: stable

Oh, CONFIG_CPUFREQ should be CONFIG_CPU_FREQ. cevt-r4k can be used
because CPUFreq will call clockevents_update_freq() after frequency
changes, and csrc-r4k is need at boot time (then be replaced by other
csrc).

Huacai

On Fri, Jul 22, 2016 at 10:27 AM, Ralf Baechle [off-list ref] wrote:
On Thu, Jul 21, 2016 at 02:27:50PM +0800, Huacai Chen wrote:
quoted
Don't register r4k sched clock when CPUFREQ enabled because sched clock
need a constant frequency.

Cc: stable@vger.kernel.org
Signed-off-by: Huacai Chen <redacted>
---
 arch/mips/kernel/csrc-r4k.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/mips/kernel/csrc-r4k.c b/arch/mips/kernel/csrc-r4k.c
index 1f91056..5131b98 100644
--- a/arch/mips/kernel/csrc-r4k.c
+++ b/arch/mips/kernel/csrc-r4k.c
@@ -82,7 +82,9 @@ int __init init_r4k_clocksource(void)

      clocksource_register_hz(&clocksource_mips, mips_hpt_frequency);

+#ifndef CONFIG_CPUFREQ
      sched_clock_register(r4k_read_sched_clock, 32, mips_hpt_frequency);
+#endif
There is no config symbol CONFIG_CPUFREQ and I think if the clock may
change, we shouldn't register it as csrc or cevt.

  Ralf
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help