Re: [patch] MIPS: OCTEON: Off by one in octeon_irq_gpio_map()
From: David Daney <hidden>
Date: 2016-07-14 15:38:46
Also in:
kernel-janitors
On 07/14/2016 03:14 AM, Dan Carpenter wrote:
It should be >= ARRAY_SIZE() instead of > ARRAY_SIZE().
Fixes: 64b139f97c01 ('MIPS: OCTEON: irq: add CIB and other fixes')
Signed-off-by: Dan Carpenter <redacted>Good catch. This would probably only matter if a malformed device tree, or buggy device driver were encountered. Acked-by: David Daney <redacted>
quoted hunk ↗ jump to hunk
diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c index 368eb49..75a4add 100644 --- a/arch/mips/cavium-octeon/octeon-irq.c +++ b/arch/mips/cavium-octeon/octeon-irq.c@@ -1260,7 +1260,7 @@ static int octeon_irq_gpio_map(struct irq_domain *d, line = (hw + gpiod->base_hwirq) >> 6; bit = (hw + gpiod->base_hwirq) & 63; - if (line > ARRAY_SIZE(octeon_irq_ciu_to_irq) || + if (line >= ARRAY_SIZE(octeon_irq_ciu_to_irq) || octeon_irq_ciu_to_irq[line][bit] != 0) return -EINVAL;