Re: [PATCH 1/6] MIPS: BMIPS: add missing console to bcm96358nb4ser
From: Jonas Gorski <hidden>
Date: 2016-06-14 14:39:23
Also in:
linux-devicetree, lkml
Hi Álvaro, On 13 June 2016 at 09:38, Álvaro Fernández Rojas [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Console definition is needed in order to avoid a warning in earlycon to console transition. Signed-off-by: Álvaro Fernández Rojas <redacted> --- arch/mips/boot/dts/brcm/bcm96358nb4ser.dts | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts index f412117..702eae2 100644 --- a/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts +++ b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts
Unfortunately I haven't seen this earlier, but please don't name the dts file bcm9* unless it's an actual reference/eval board from Broadcom. A more sensible name would be neufbox4-sercom.dts or bcm6358-neufbox4-sercom.dts. Regards Jonas