Thread (26 messages) 26 messages, 9 authors, 2016-03-18

Re: [PATCH v2 1/5] printk/nmi: Generic solution for safe printk in NMI

From: Petr Mladek <pmladek@suse.com>
Date: 2015-12-04 16:57:52
Also in: linux-arm-kernel, linux-sh, linuxppc-dev, lkml, sparclinux

On Wed 2015-12-02 00:24:49, Jiri Kosina wrote:
On Fri, 27 Nov 2015, Petr Mladek wrote:
quoted
MN10300 has its own implementation for entering and exiting NMI 
handlers. It does not call nmi_enter() and nmi_exit(). Please, find 
below an updated patch that adds printk_nmi_enter() and 
printk_nmi_exit() to the custom entry points. Then we could add HAVE_NMI 
to arch/mn10300/Kconfig and avoid the above warning.
Hmm, so what exactly would go wrong if MN10300 (whatever that architecture 
is) would call nmi_enter() and nmi_exit() at the places where it's 
starting and finishing NMI handler?
quoted
From a cursory look, it seems like most (if not all) of the things called 
from nmi_{enter,exit}() would be nops there anyway.
Good point. Max mentioned in the other main that the NMI handler
should follow the NMI ruler. I do not why it could not work.
In fact, it might improve things, e.g. nmi_enter() blocks
recursive NMIs.

I think that it will move it into a separate patch, thought.

Best Regards,
Petr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help