Re: [PATCH 2/2] MIPS: ath79: add irq chip ar7240-misc-intc
From: Alban <albeu@free.fr>
Date: 2015-08-10 18:22:01
Also in:
linux-devicetree
On Thu, 6 Aug 2015 12:43:25 +0200 Alexander Couzens [off-list ref] wrote:
The ar7240 misc irq chip use ack handler instead of ack_mask handler. All new ath79 SoCs use the ar7240 misc irq chip
except the ar913x family according to the later documentation. [...]
quoted hunk
--- a/arch/mips/ath79/irq.c +++ b/arch/mips/ath79/irq.c@@ -315,8 +315,17 @@ static int __init ar7100_misc_intc_of_init( return ath79_misc_intc_of_init(node, parent); } +static int __init ar7240_misc_intc_of_init( + struct device_node *node, struct device_node *parent) +{ + ath79_misc_irq_chip.irq_ack = ar724x_misc_irq_ack; + return ath79_misc_intc_of_init(node, parent); +} + IRQCHIP_DECLARE(ar7100_misc_intc, "qca,ar7100-misc-intc", ar7100_misc_intc_of_init); +IRQCHIP_DECLARE(ar7240_misc_intc, "qca,ar7240-misc-intc", + ar7240_misc_intc_of_init);
It would be better to keep the same formatting as the surrounding code. Could you keep the IRQCHIP_DECLARE() together with the init function and remove the extra blank line? Alban