Thread (9 messages) 9 messages, 3 authors, 2015-08-19

Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API

From: Ralf Baechle <hidden>
Date: 2015-08-19 21:03:40
Also in: lkml, stable

On Sun, Aug 09, 2015 at 02:21:11PM +0200, Hauke Mehrtens wrote:
Date:   Sun, 09 Aug 2015 14:21:11 +0200
From: Hauke Mehrtens <hauke@hauke-m.de>
To: Alban Bedel <albeu@free.fr>, linux-mips@linux-mips.org, Ralf Baechle
 [off-list ref]
CC: Andrew Bresticker <redacted>, Qais Yousef
 [off-list ref], Wolfram Sang [off-list ref], Sergey
 Ryazanov [off-list ref], Gabor Juhos [off-list ref],
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API
Content-Type: text/plain; charset=windows-1252

On 04/19/2015 02:30 PM, Alban Bedel wrote:
quoted
Make the code simpler and open the way for device tree clocks.

Signed-off-by: Alban Bedel <albeu@free.fr>
---
 arch/mips/Kconfig       |  1 +
 arch/mips/ath79/clock.c | 29 ++---------------------------
 2 files changed, 3 insertions(+), 27 deletions(-)
I think this should be send at least to stable 4.1, because it fixes a
linking problem we are seeing in OpenWrt.

ath79 does not export clk_set_rate() and clk_round_rate(), but some
drivers are using it and they are not using the inline dummy method,
because CONFIG_HAVE_CLK is set for ath79.

ERROR: "clk_set_rate" [drivers/usb/phy/phy-generic.ko] undefined!
ERROR: "clk_round_rate" [drivers/media/v4l2-core/videodev.ko] undefined!
ERROR: "clk_set_rate" [drivers/media/v4l2-core/videodev.ko] undefined!
Ok.  Will post the the patch in a separate email.

  Ralf
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help