On Jun 25, 2015, at 4:32 AM, Florian Fainelli [off-list ref] wrote:

+Brian,

On 23/06/15 23:08, Jaedon Shin wrote:

quoted

Add NAND device nodes to BMIPS based BCM7346 platform.

Signed-off-by: Jaedon Shin <redacted>
---

[snip]

quoted

+
+&nand0 {
+	status = "okay";
+
+	nandcs@1 {
+		compatible = "brcm,nandcs";
+		reg = <1>;
+		nand-ecc-step-size = <512>;
+		nand-ecc-strength = <8>;
+		nand-on-flash-bbt;
+
+		#size-cells = <2>;
+		#address-cells = <2>;
+
+		flash1.rootfs0@0 {
+			reg = <0x0 0x0 0x0 0x80000000>;
+		};
+
+		flash1.rootfs1@80000000 {
+			reg = <0x0 0x80000000 0x0 0x80000000>;
+		};
+	};
+};

Should we create something like brcmnand-cs1-512-8 to reduce the amount
of duplication between DTS files?
-- 
Florian

I Think that is not duplication.

I have no reference boards, but this node is maybe explaining for hardware
description of the BCM97346DBSMB reference board. The nodes are changed by
EBI CS and ECC capabilities of NAND flash. I used brcmnand-cs2-512-4 and
brcmnand-cs1-512-4 for others.