Re: [PATCH/RFC 4/8] serial: pxa: Add fifo-size and {big,native}-endian properties
From: Arnd Bergmann <arnd@arndb.de>
Date: 2014-11-12 09:02:22
Also in:
linux-devicetree, linux-serial
On Wednesday 12 November 2014 00:46:29 Kevin Cernekee wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/tty/serial/pxa.c b/drivers/tty/serial/pxa.c index 21b7d8b..78ed7ee 100644 --- a/drivers/tty/serial/pxa.c +++ b/drivers/tty/serial/pxa.c@@ -60,13 +60,19 @@ struct uart_pxa_port { static inline unsigned int serial_in(struct uart_pxa_port *up, int offset) { offset <<= 2; - return readl(up->port.membase + offset); + if (!up->port.big_endian) + return readl(up->port.membase + offset); + else + return ioread32be(up->port.membase + offset); }
How about making this a different UPIO type and using UPIO_MEM32/UPIO_MEM32BE to tell the difference rather than a separate flag? Arnd