On Mon, 27 Oct 2014, Ren, Qiaowei wrote:

On 2014-10-24, Thomas Gleixner wrote:

quoted

On Sun, 12 Oct 2014, Qiaowei Ren wrote:

quoted

+int mpx_enable_management(struct task_struct *tsk) {
+	struct mm_struct *mm = tsk->mm;
+	void __user *bd_base = MPX_INVALID_BOUNDS_DIR;

What's the point of initializing bd_base here. I had to look twice to
figure out that it gets overwritten by task_get_bounds_dir()

I just want to put task_get_bounds_dir() outside mm->mmap_sem holding.

What you want is not interesting at all. What's interesting is what
you do and what you send for review.
 
Thanks,

	tglx