On 08/22/2013 03:55:20 PM, David Daney wrote:

On 08/22/2013 01:41 PM, Rob Landley wrote:

quoted

On 08/22/2013 07:58:26 AM, Geert Uytterhoeven wrote:

quoted

On Wed, Aug 21, 2013 at 9:51 PM, Sam Ravnborg [off-list ref]  
wrote:

quoted

quoted

quoted

The series touches also m68k, sh, mips and unicore32.
These architectures magically select a cross compiler if ARCH  

!=
SUBARCH.

quoted

quoted

quoted

Do really need that behavior?

This does remove functionality.
It allows to build a kernel using e.g. "make ARCH=m68k".

Perhaps this can be moved to generic code? Most (not all!)

cross-toolchains

quoted

quoted

are called $ARCH-{unknown-,}linux{,-gnu}.
Exceptions are e.g. am33_2.0-linux and bfin-uclinux.

Today you can specify CROSS_COMPILE in Kconfig.
With this we should be able to remove these hacks.

The correct CROSS_COMPILE value depends on the host environment, not
on the target configuration.

Actually it depends on _both_.

I think the important issue is not the exact dependencies of the  
value of CROSS_COMPILE, but rather that it varies enough that  
automatically choosing a value based on SUBARCH often gives the wrong  
result.

Removing SUBARCH and setting CROSS_COMPILE either from the make  
command line (or environment) or the config file, is a good idea  
because it simplifies the build system, makes things clearer, and  
yields more predictable results.

David Daney

Agreed. Expecting the build to guess the right $CROSS_COMPILE is like  
expecting it to guess the right $PATH. It should be specified, not  
heuristically probed.

Rob
From juhosg@openwrt.org Fri Aug 23 08:31:49 2013
Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 23 Aug 2013 08:31:51 +0200 (CEST)
Received: from arrakis.dune.hu ([78.24.191.176]:41453 "EHLO arrakis.dune.hu"
        rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP
        id S6817128Ab3HWGbtUv18e (ORCPT <rfc822;linux-mips@linux-mips.org>);
        Fri, 23 Aug 2013 08:31:49 +0200
Received: from arrakis.dune.hu (localhost [127.0.0.1])
        by arrakis.dune.hu (Postfix) with ESMTP id 3050E280826;
        Fri, 23 Aug 2013 08:31:20 +0200 (CEST)
Received: from localhost.localdomain (catvpool-576570d8.szarvasnet.hu [87.101.112.216])
        by arrakis.dune.hu (Postfix) with ESMTPSA;
        Fri, 23 Aug 2013 08:31:20 +0200 (CEST)
From:   Gabor Juhos <redacted>
To:     Ralf Baechle <redacted>
Cc:     linux-mips@linux-mips.org, John Crispin <redacted>,
        Gabor Juhos [off-list ref]
Subject: [PATCH v2 3/3] MIPS: ralink: mt7620: add spi clock definition
Date:   Fri, 23 Aug 2013 08:31:32 +0200
Message-Id: [ref]
X-Mailer: git-send-email 1.7.10
In-Reply-To: [ref]
References: [ref]
Return-Path: [off-list ref]
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 37652
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: juhosg@openwrt.org
Precedence: bulk
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
List-software: Ecartis version 1.0.0
List-Id: linux-mips <linux-mips.eddie.linux-mips.org>
X-List-ID: linux-mips <linux-mips.eddie.linux-mips.org>
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
X-list: linux-mips
Content-Length: 1054
Lines: 34

From: John Crispin <redacted>

Register a clock device for the SPI block of the
MT7620 SoC. The clock device will be used by the
SPI host controller driver to determine the base
clock of the controller.

Signed-off-by: John Crispin <redacted>
Signed-off-by: Gabor Juhos <redacted>
---
Changes since v1:
  - rebase against the mips-for-linux-next branch of the
    upstream-sfr.git tree

This makes the following patch obsolete:
  https://patchwork.linux-mips.org/patch/5672/
---
 arch/mips/ralink/mt7620.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
index 6c37c9d..988324b 100644
--- a/arch/mips/ralink/mt7620.c
+++ b/arch/mips/ralink/mt7620.c

@@ -318,6 +318,7 @@ void __init ralink_clk_init(void)
 	ralink_clk_add("10000100.timer", periph_rate);
 	ralink_clk_add("10000120.watchdog", periph_rate);
 	ralink_clk_add("10000500.uart", periph_rate);
+	ralink_clk_add("10000b00.spi", sys_rate);
 	ralink_clk_add("10000c00.uartlite", periph_rate);
 }
 

-- 
1.7.10