Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()
From: Bjorn Helgaas <bhelgaas@google.com>
Date: 2012-09-15 22:23:59
Also in:
linux-alpha, linux-arm-kernel, linux-pci, linux-sh, lkml, sparclinux
On Sat, Sep 15, 2012 at 1:53 AM, Thierry Reding [off-list ref] wrote:
On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote:quoted
On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding [off-list ref] wrote:quoted
--- a/drivers/pci/setup-irq.c +++ b/drivers/pci/setup-irq.c@@ -17,6 +17,14 @@ #include <linux/ioport.h> #include <linux/cache.h> +void __devinit __weak pcibios_update_irq(struct pci_dev *dev, int irq) +{ +#ifdef CONFIG_PCI_DEBUG + printk(KERN_DEBUG "PCI: Assigning IRQ %02d to %s\n", irq, + pci_name(dev));pr_debug()? Or even better, dev_dbg()?The problem with pr_debug() and dev_dbg() is that they will be compiled out if DEBUG is not defined. Perhaps we should pass -DDEBUG if PCI_DEBUG is configured and make this dev_dbg()?
Sorry, fat-fingered the previous empty response.
We already have this in drivers/pci/Makefile:
ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
so dev_dbg() should be perfect.