Thread (5 messages) 5 messages, 3 authors, 2012-08-26

Re: [PATCH V3] usb: gadget: bcm63xx UDC driver

From: Sebastian Andrzej Siewior <hidden>
Date: 2012-08-26 19:30:28

On Sat, Aug 25, 2012 at 12:44:19PM -0700, Kevin Cernekee wrote:
When bcm63xx_udc is in EP0_IN_FAKE_STATUS_PHASE, it won't issue any
more setup() callbacks until the 0-byte reply arrives from the gadget
driver.  If the host sends a setup request, the callback will be held
off until after the (unused) status reply.  This keeps the gadget
driver from getting confused by out-of-sequence events.
Okay. Then it works as requested :)
quoted
- What happens if the host is faster than the UDC. SetConfig returns in
  usb-storage with "DELAYED_STATUS". HW Acks this. Could the Host send another
  request before the gadget queues the ep0 request?
Could you please clarify if this is the sequence of events you are describing:

1) Host sends a valid SET_CONFIGURATION request to a mass storage gadget

2) Hardware instantly auto-acks the request, completing the status
phase and allowing the host to proceed with another ep0 request

3) bcm63xx_udc sends a spoofed SET_CONFIGURATION setup packet to the
gadget driver

4) setup() callback returns USB_GADGET_DELAYED_STATUS (0x7fff) but
doesn't queue up a reply

5) Host sends another setup packet before
usb_composite_setup_continue() is called to send the 0-byte status
reply
exactly 
 
If so, the next steps should look like:

6) bcm63xx_udc takes a data IRQ, and sets ep0_req_completed

7) bcm63xx_udc stays in EP0_IN_FAKE_STATUS_PHASE until the 0-byte
reply is received from usb_composite_setup_continue()

8) usb_composite_setup_continue() eventually sends the 0-byte reply

9) bcm63xx_udc returns to EP0_IDLE and notices that ep0_req_completed is now set

10) bcm63xx_ep0_do_setup() looks at the new request, and performs the
setup() callback for the new setup request
Okay. This sounds good.
11) Data/status phases are handled as usual
Please tell you HW vendor that this auto ack feature is complete non sense
unless you already have :)

Sebastian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help