On 30/04/12 19:54, David Daney wrote:

On 04/30/2012 10:46 AM, John Crispin wrote:

quoted

On MIPS we want to call of_irq_map_pci from inside

arch/mips/include/asm/pci.h:extern int pcibios_map_irq(
                const struct pci_dev *dev, u8 slot, u8 pin);

For this to work we need to change several functions to const usage.

I think there is a mismatch on this throughout the kernel.

Properly fixing it requires touching many more places than these.
Although I haven't tried it, I wouldn't be surprised if doing this
caused warnings to appear in non-MIPS code.

Ralf had a patch at one point that tried to make this consistent
tree-wide, but it is not yet applied.

David Daney

Hi,

Ok, lets see what Ralf has to say.

I just tested the patch on x86 with OF enabled and drivers turned on
that use the API. I did not see any errors appear.

Thanks,
John