[PATCH 8/8] MIPS: sync-r4k: remove redundant irq operation

[V1 PATCH 0/8] patchset focus on MIPS SMP woes · Yong Zhang <hidden> · 2012-05-21
[PATCH 1/8] MIPS: Octeon: delay enable irq to ->smp_finish() · Yong Zhang <hidden> · 2012-05-21
[PATCH 2/8] MIPS: BMIPS: delay irq enable to ->smp_finish() · Yong Zhang <hidden> · 2012-05-21
[PATCH 3/8] MIPS: SMTC: delay irq enable to ->smp_finish() · Yong Zhang <hidden> · 2012-05-21
[PATCH 4/8] MIPS: Yosemite: delay irq enable to ->smp_finish() · Yong Zhang <hidden> · 2012-05-21
[PATCH 5/8] MIPS: call ->smp_finish() a little late · Yong Zhang <hidden> · 2012-05-21
[PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled · Yong Zhang <hidden> · 2012-05-21
Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled · Sergei Shtylyov <hidden> · 2012-05-21
Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled · Yong Zhang <hidden> · 2012-05-22
Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled · Srivatsa S. Bhat <hidden> · 2012-05-21
Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled · Yong Zhang <hidden> · 2012-05-22
Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled · Srivatsa S. Bhat <hidden> · 2012-05-28
Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled · Yong Zhang <hidden> · 2012-05-29
[PATCH 7/8] MIPS: smp: Warn on too early irq enable · Yong Zhang <hidden> · 2012-05-21
[PATCH 8/8] MIPS: sync-r4k: remove redundant irq operation · Yong Zhang <hidden> · 2012-05-21

STALE5130d REVIEWED: 1 (0M)

Revisions (2)

2012-05-17 v1 [diff vs current]
2012-05-21 v1 current

From: Yong Zhang <hidden>
Date: 2012-05-21 06:02:31
Also in: lkml
Subsystem: mips, the rest · Maintainers: Thomas Bogendoerfer, Linus Torvalds

From: Yong Zhang <redacted>

Since we have delayed irq enabling to ->smp_finish()

Signed-off-by: Yong Zhang <redacted>
Acked-by: David Daney <redacted>
---
 arch/mips/kernel/sync-r4k.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/arch/mips/kernel/sync-r4k.c b/arch/mips/kernel/sync-r4k.c
index 99f913c..842d55e 100644
--- a/arch/mips/kernel/sync-r4k.c
+++ b/arch/mips/kernel/sync-r4k.c

@@ -111,7 +111,6 @@ void __cpuinit synchronise_count_master(void)
 void __cpuinit synchronise_count_slave(void)
 {
 	int i;
-	unsigned long flags;
 	unsigned int initcount;
 	int ncpus;

@@ -123,8 +122,6 @@ void __cpuinit synchronise_count_slave(void)
 	return;
 #endif
 
-	local_irq_save(flags);
-
 	/*
 	 * Not every cpu is online at the time this gets called,
 	 * so we first wait for the master to say everyone is ready

@@ -154,7 +151,5 @@ void __cpuinit synchronise_count_slave(void)
 	}
 	/* Arrange for an interrupt in a short while */
 	write_c0_compare(read_c0_count() + COUNTON);
-
-	local_irq_restore(flags);
 }
 #undef NR_LOOPS

-- 
1.7.5.4

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help