On Mon, 14 May 2012 11:13:41 -0700, David Daney [off-list ref] wrote:

On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote:

quoted

Hi David,
A few comments.

On Sat, May 12, 2012 at 3:04 AM, David Daney[off-list ref]  wrote:

[...]

quoted

quoted

+
+#define DRV_VERSION "2.0" /* Version 1 was the out-of-tree driver */

This could be given a miss. As it is less meaningful once accepted.

Well, this leads to the question, what is the purpose of the 
'MODULE_VERSION()' macro?  If I use that, I need to populate it with a 
value.

Don't use MODULE_VERSION.  Just because it is there doesn't mean you
need to use it.  :-)  You'll notice that none of the other spi drivers
have it.

g.