Re: [PATCH] staging/octeon: Software should check the checksum of no tcp/udp packets
From: David Daney <hidden>
Date: 2011-09-26 19:50:45
Also in:
netdev
On 09/25/2011 06:08 PM, rongqing.li@windriver.com wrote:
From: Roy.Li<redacted> Icmp packets with wrong checksum are never dropped since skb->ip_summed is set to CHECKSUM_UNNECESSARY. When icmp packets with wrong checksum pass through the octeon net driver, the not_IP, IP_exc, L4_error hardware indicators show no error. so the driver sets CHECKSUM_UNNECESSARY on skb->ip_summed. L4_error only works for TCP/UDP, not for ICMP. Signed-off-by: Roy.Li<redacted>
We found the same problem, but have not yet sent the patch to fix it. This looks fine to me, Acked-by: David Daney <redacted> I would let davem, Ralf and Greg KH fight over who gets to merge it. David Daney
quoted hunk ↗ jump to hunk
--- drivers/staging/octeon/ethernet-rx.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 1a7c19a..1747024 100644 --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c@@ -411,7 +411,8 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget) skb->protocol = eth_type_trans(skb, dev); skb->dev = dev; - if (unlikely(work->word2.s.not_IP || work->word2.s.IP_exc || work->word2.s.L4_error)) + if (unlikely(work->word2.s.not_IP || work->word2.s.IP_exc || + work->word2.s.L4_error || !work->word2.s.tcp_or_udp)) skb->ip_summed = CHECKSUM_NONE; else skb->ip_summed = CHECKSUM_UNNECESSARY;