Thread (23 messages) 23 messages, 9 authors, 2011-06-15

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2011-06-14 20:32:08
Also in: linux-alpha, linux-arch, linux-arm-kernel, linux-m68k, linuxppc-dev

On Tue, Jun 14, 2011 at 21:08, Ralf Baechle [off-list ref] wrote:
The PC parallel port Kconfig as acquired one of those messy terms to
describe it's architecture dependencies:

      depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \
              (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN

This isn't just ugly - it also almost certainly describes the dependencies
too coarse grainedly.  This is an attempt at cleaing the mess up.
quoted hunk ↗ jump to hunk
--- a/arch/m68k/Kconfig.mmu
+++ b/arch/m68k/Kconfig.mmu
@@ -399,6 +399,7 @@ config ISA
       bool
       depends on Q40 || AMIGA_PCMCIA
       default y
+       select PARPORT_PC
Why do you select PARPORT_PC here instead of HAVE_PC_PARPORT?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help