Re: [PATCH] MSP71xx: request_irq() failure ignored in msp_pcibios_config_access()
From: Roel Kluin <hidden>
Date: 2009-09-01 20:18:01
Subsystem:
mips, the rest · Maintainers:
Thomas Bogendoerfer, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2009-09-01 · [PATCH] MSP71xx: request_irq() failure ignored in msp_pcibios_config_access() · Roel Kluin <hidden>
Produce an error if request_irq() fails. Signed-off-by: Roel Kluin <redacted> ---
quoted
+ return -1;
I'd personally suggest to return the actual value returned by request_irq, instead of returning -EPERM..... ;) Ithamar.
The comments at the header states that it returns -1 on failure, and so do the callers as well, but if preferred, below is as you suggest. Thanks,
diff --git a/arch/mips/pci/ops-pmcmsp.c b/arch/mips/pci/ops-pmcmsp.c
index 109c95c..32548b5 100644
--- a/arch/mips/pci/ops-pmcmsp.c
+++ b/arch/mips/pci/ops-pmcmsp.c@@ -385,6 +385,7 @@ int msp_pcibios_config_access(unsigned char access_type, unsigned long intr; unsigned long value; static char pciirqflag; + int ret; #if defined(CONFIG_PMC_MSP7120_GW) || defined(CONFIG_PMC_MSP7120_EVAL) unsigned int vpe_status; #endif
@@ -402,11 +403,13 @@ int msp_pcibios_config_access(unsigned char access_type, * allocation assigns an interrupt handler to the interrupt. */ if (pciirqflag == 0) { - request_irq(MSP_INT_PCI,/* Hardcoded internal MSP7120 wiring */ + ret = request_irq(MSP_INT_PCI,/* Hardcoded internal MSP7120 wiring */ bpci_interrupt, IRQF_SHARED | IRQF_DISABLED, "PMC MSP PCI Host", preg); + if (ret != 0) + return ret; pciirqflag = ~0; }