Hi Florian,

On Fri, Aug 21, 2009 at 6:53 PM, Florian Fainelli[off-list ref] wrote:

Le Tuesday 18 August 2009 18:01:40 Florian Fainelli, vous avez écrit :

quoted

Le Tuesday 18 August 2009 16:56:37 Sergei Shtylyov, vous avez écrit :

quoted

Hello.

Florian Fainelli wrote:

quoted

This patch adds the board code to register a per-board au1000-eth
platform device to be used wit the au1000-eth platform driver in a
subsequent patch. Note that the au1000-eth driver knows about the
default driver settings such that we do not need to pass any
platform_data informations in most cases except db1x00.

    Sigh, NAK...
    Please don't register the SoC device per board, do it in
alchemy/common/platfrom.c and find a way to pass the board specific
platform data from the board file there instead -- something like
arch/arm/mach-davinci/usb.c does.

Ok, like I promised, this was the per-board device registration. Do you
prefer something like this: --
From fd75b7c7fa3c05c21122c43e43260d2785475a79 Mon Sep 17 00:00:00 2001
From: Florian Fainelli <florian@openwrt.org>
Date: Tue, 18 Aug 2009 17:53:21 +0200
Subject: [PATCH] alchemy: add au1000-eth platform device (v2)

This patch makes the board code register the au1000-eth
platform device. The au1000-eth platform data can be
overriden with the au1xxx_override_eth0_cfg function
like it has to be done for the Bosporus board.

Sergei, any comments on that version? What about you Manuel?

Obviously I *much* prefer your first version, but I'm okay with this
second version too.

(I usually only comment if I don't like things, so take my silence as
approval).

Thanks for your work!

Manuel Lauss