Thread (1 message) 1 message, 1 author, 2007-06-30

Re: [PATCH] TXx9 SPI controller driver (take 2)

From: Atsushi Nemoto <hidden>
Date: 2007-06-30 17:34:14
Also in: linux-spi

Possibly related (same subject, not in this thread)

On Sat, 30 Jun 2007 09:53:19 -0700, David Brownell [off-list ref] wrote:
quoted
This is a driver for SPI controller built into TXx9 MIPS SoCs.
This driver is derived from arch/mips/tx4938/toshiba_rbtx4938/spi_txx9.c.

Signed-off-by: Atsushi Nemoto <redacted>
---
Changes from previous version:
Better, but still not there yet.
Thanks!  I'll be back with take 3 patch.
quoted
+	txx9spi_cs_func(spi, c, 0, 1000000000 / 2 / spi->max_speed_hz);
You still use this confusing A/2/B syntax.  Please
rewrite that using one "/" and one "*".  (And there
is similar usage elsewhere.)
The compiler will optimize "1000000000 / 2 / spi->max_speed_hz" into
"500000000 / spi->max_speed_hz", so it can be treat as one "/", no?

---
Atsushi Nemoto
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help