Thread (1 message) 1 message, 1 author, 2002-11-09

Re: 64-bit little endian semaphore bug

From: Ralf Baechle <hidden>
Date: 2002-11-09 19:45:46

On Fri, Nov 08, 2002 at 03:37:38PM -0800, Kip Walker wrote:
In the 64-bit kernel, the semaphore structure (like the 32-bit kernel)
has waking and count fields swizzled so they line up the same in a
64-bit double word for either endian.  However, the semaphore-helper.h
function waking_non_zero_interruptible still has specialized code for
little-endian manipulation of the fields as though they are swapped.

Patch is attached, and fixes a pipe deadlock I was seeing (both the
reader and writer were down'ing the semaphore).

patch is against 2.5, but should be clean against 2.4 also.
Patch is ok.  I tweaked it slightly to make the 2.4 and 2.5 versions
identical.

General request to everybody - cc me on all patches that you wish to
submit even if you're posting them to some list.

  Ralf
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help