Re: [PATCH 2.5] R5000 secondary cache support
From: Ralf Baechle <hidden>
Date: 2002-09-02 22:39:03
On Mon, Aug 26, 2002 at 09:49:37PM +0200, Vivien Chappelier wrote:
I've tested and updated Brian Murphy's R5K SC patch to the 2.5 kernel. I've also changed a few comments, changed Page_Invalidate operation to R5K_Page_Invalidate_S to be consistent with the naming of R4K cache ops, and simplified the r5k_dma_cache_inv_sc routine (no need for two 'while'). And I've also removed the extra crap for in config-shared.in in Brian's latest diff (removing spaces/formating) :) I've also tested this patch at runtime, it runs fine (as far as a 2.5.8 can run fine :)). This patch is for both 2.5.8/mips64 and 2.5.8/mips. Please comment and/or apply,
Mostly ok. I just don't like that you force CONFIG_BOARD_SCACHE on everybody with a R5000 or Nevada. Cobalt Qube 1 for example has a Nevada which never has a second level cache, whatever type. So if you could fix that eventually :-) Ralf