Re: [PATCH v11 1/4] dt-bindings: pinctrl: mt8195: add rsel define
From: Chen-Yu Tsai <wenst@chromium.org>
Date: 2021-09-01 04:36:00
Also in:
linux-arm-kernel, linux-devicetree, linux-gpio, lkml
On Mon, Aug 30, 2021 at 8:36 AM Zhiyong Tao [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch adds rsel define for mt8195. Signed-off-by: Zhiyong Tao <redacted> --- include/dt-bindings/pinctrl/mt65xx.h | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/include/dt-bindings/pinctrl/mt65xx.h b/include/dt-bindings/pinctrl/mt65xx.h index 7e16e58fe1f7..f5934abcd1bd 100644 --- a/include/dt-bindings/pinctrl/mt65xx.h +++ b/include/dt-bindings/pinctrl/mt65xx.h@@ -16,6 +16,15 @@ #define MTK_PUPD_SET_R1R0_10 102 #define MTK_PUPD_SET_R1R0_11 103 +#define MTK_PULL_SET_RSEL_000 200 +#define MTK_PULL_SET_RSEL_001 201 +#define MTK_PULL_SET_RSEL_010 202 +#define MTK_PULL_SET_RSEL_011 203 +#define MTK_PULL_SET_RSEL_100 204 +#define MTK_PULL_SET_RSEL_101 205 +#define MTK_PULL_SET_RSEL_110 206 +#define MTK_PULL_SET_RSEL_111 207
Could you keep the spacing between constants tighter, or have no spacing at all? Like having MTK_PULL_SET_RSEL_000 defined as 104 and so on. This would reduce the chance of new macro values colliding with actual resistor values set in the datasheets, plus a contiguous space would be easy to rule as macros. ChenYu
#define MTK_DRIVE_2mA 2 #define MTK_DRIVE_4mA 4 #define MTK_DRIVE_6mA 6 -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek