Hi Linus,

On Mon, Jan 18, 2021 at 10:55 PM Linus Walleij [off-list ref] wrote:

So for offset 0..14 this becomes bits
0, 1, 2, 4, 5, 6, 8, 9, 10, 12  ... 18

What is the logic in this and is it what you intend?

Yes. Bit 0..2 are phy 0's LED 0..2, bit 4..6 are phy 1's LED 0..2, etc.

Please add a comment explaining what the offset is supposed
to become for offsets 0..14 and why.

I already added to mt7530.h, perhaps I should copy it here?

quoted

+       gc->ngpio = 15;

And it really IS 15 not 16? Not that I know network equipment
very well...

Yes, 3 LEDs for each phy.

Yours,
Linus Walleij

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek