Re: [PATCH net-next v3 2/2] net: ethernet: mediatek: modify GDM to send packets to the PDMA for RX
From: John Crispin <john@phrozen.org>
Date: 2016-08-25 12:10:38
Also in:
netdev
On 25/08/2016 04:26, Nelson Chang wrote:
quoted hunk ↗ jump to hunk
Because we change to use the PDMA as the Ethernet RX DMA engine, the patch modifies to set GDM to send packets to PDMA for RX. Signed-off-by: Nelson Chang <redacted> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++-- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 0 2 files changed, 2 insertions(+), 2 deletions(-) mode change 100755 => 100644 drivers/net/ethernet/mediatek/mtk_eth_soc.c mode change 100755 => 100644 drivers/net/ethernet/mediatek/mtk_eth_soc.hdiff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c old mode 100755 new mode 100644 index cbeb793..c47fef4 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c@@ -1473,9 +1473,9 @@ static int __init mtk_hw_init(struct mtk_eth *eth) for (i = 0; i < 2; i++) { u32 val = mtk_r32(eth, MTK_GDMA_FWD_CFG(i)); - /* setup the forward port to send frame to QDMA */ + /* setup the forward port to send frame to PDMA */ val &= ~0xffff; - val |= 0x5555; + val |= 0x0000;
masking it and then setting it to 0 makes no sense. simply remove the 2nd line. John
quoted hunk ↗ jump to hunk
/* Enable RX checksum */ val |= MTK_GDMA_ICS_EN | MTK_GDMA_TCS_EN | MTK_GDMA_UCS_EN;diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h old mode 100755 new mode 100644