On Tue 2021-02-16 09:37:45, Thomas Zimmermann wrote:
Hi
Am 15.02.21 um 12:40 schrieb Sakari Ailus:
quoted
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
large number of temporary variables at the same time.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 5 ++--
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 5 ++--
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 5 ++--
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 5 ++--
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 ++--
.../arm/display/komeda/komeda_format_caps.h | 11 --------
.../arm/display/komeda/komeda_framebuffer.c | 4 +--
.../gpu/drm/arm/display/komeda/komeda_plane.c | 6 ++---
drivers/gpu/drm/arm/malidp_mw.c | 7 ++----
drivers/gpu/drm/drm_atomic.c | 8 ++----
drivers/gpu/drm/drm_crtc.c | 7 ++----
drivers/gpu/drm/drm_fourcc.c | 25 -------------------
drivers/gpu/drm/drm_framebuffer.c | 11 +++-----
drivers/gpu/drm/drm_mipi_dbi.c | 5 ++--
drivers/gpu/drm/drm_plane.c | 8 ++----
.../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 5 ++--
drivers/gpu/drm/i915/display/intel_display.c | 14 +++--------
.../drm/i915/display/intel_display_debugfs.c | 19 ++++++--------
drivers/gpu/drm/i915/display/intel_sprite.c | 6 ++---
drivers/gpu/drm/mcde/mcde_display.c | 6 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++---
drivers/gpu/drm/nouveau/nouveau_display.c | 9 +++----
drivers/gpu/drm/radeon/atombios_crtc.c | 10 +++-----
drivers/gpu/drm/sun4i/sun4i_backend.c | 6 ++---
drivers/gpu/drm/vkms/vkms_writeback.c | 7 ++----
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 15 +++++------
include/drm/drm_fourcc.h | 1 -
27 files changed, 64 insertions(+), 157 deletions(-)
This is a nice patchset. For the driver-related changes:
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
But landing this patch will certainly give us build errors. There are at
least 3 git trees involved: drm-misc-next, amd and i915. I'd expect at least
one of them to have additional changes that still require
drm_get_format_name().
IMHO we should remove drm_get_format_name() in a later patch. Please remove
the changes in drm_fourcc.{c,h} from this patch and maybe add a TODO comment
to the declaration that the function is supposed to be removed.
I would merge the patchset through drm-misc-next. And the final removal
patch during the next cycle. Ok?
Sounds like a plan. I am fine with it from the vsprintf side.
Best Regards,
Petr