On Mon, Feb 15, 2021 at 03:56:50PM +0200, Sakari Ailus wrote:
On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote:
quoted
On Mon, Feb 15, 2021 at 01:40:28PM +0200, Sakari Ailus wrote:
quoted
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
This version I almost like, feel free to add
Reviewed-by: From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
after considering addressing below nit-picks.
quoted
quoted
+Examples::
+
+ %p4cc BG12 little-endian (0x32314742)
No examples with spaces / non-printable / non-ascii characters
I can sure add an example that has a space. But do you think I really
should add an example where invalid information is being printed?
I think you have to provide better coverage of what user can get out of this.
Perhaps one example with space and non-printable character is enough.
quoted
quoted
+ char output[sizeof("1234 little-endian (0x01234567)")];
1234 -> ABCD ? (Or XY12 to be closer to the reality)
I count in numbers... albeit the hexadecimal number there starts from zero.
I guess both would work though.
0123 would be consistent.
Since letters can be printed the above is confusing a bit. I think XY12 is
closer to the reality than 0123.
--
With Best Regards,
Andy Shevchenko