Thread (18 messages) 18 messages, 7 authors, 2021-02-02

Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

From: Lyude Paul <lyude@redhat.com>
Date: 2021-02-01 21:55:48
Also in: dri-devel, lkml

This is entirely unrelated to this thread, but I noticed when going through dri-
devel that this email is somehow dated two days in the future from now.

On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote:
Am 30.01.21 um 19:47 schrieb Joe Perches:
quoted
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
quoted
Use semicolons and braces.
Ping?
  
quoted
Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Christian König <christian.koenig@amd.com>

Do you have commit rights to drm-misc-next?
quoted
quoted
---
  drivers/dma-buf/st-dma-fence.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-
fence.c
index e593064341c8..c8a12d7ad71a 100644
--- a/drivers/dma-buf/st-dma-fence.c
+++ b/drivers/dma-buf/st-dma-fence.c
@@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
                        dma_fence_signal(f1);
  

                smp_store_mb(cb.seen, false);
-               if (!f2 || dma_fence_add_callback(f2, &cb.cb,
simple_callback))
-                       miss++, cb.seen = true;
+               if (!f2 ||
+                   dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
+                       miss++;
+                       cb.seen = true;
+               }
  

                if (!t->before)
                        dma_fence_signal(f1);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- 
Sincerely,
   Lyude Paul (she/her)
   Software Engineer at Red Hat
   
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help