Thread (18 messages) 18 messages, 7 authors, 2021-02-02

Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

From: Christian König <christian.koenig@amd.com>
Date: 2021-01-31 19:49:11
Also in: dri-devel, lkml

Am 31.01.21 um 18:39 schrieb Joe Perches:
On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote:
quoted
Am 30.01.21 um 19:47 schrieb Joe Perches:
quoted
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
quoted
Use semicolons and braces.
Ping?
quoted
Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Christian König <christian.koenig@amd.com>

Do you have commit rights to drm-misc-next?
No.
Pushed.

Thanks for the help,
Christian.
quoted
quoted
quoted
---
   drivers/dma-buf/st-dma-fence.c | 7 +++++--
   1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
index e593064341c8..c8a12d7ad71a 100644
--- a/drivers/dma-buf/st-dma-fence.c
+++ b/drivers/dma-buf/st-dma-fence.c
@@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
   			dma_fence_signal(f1);

   		smp_store_mb(cb.seen, false);
-		if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
-			miss++, cb.seen = true;
+		if (!f2 ||
+		    dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
+			miss++;
+			cb.seen = true;
+		}

   		if (!t->before)
   			dma_fence_signal(f1);
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help