Re: [PATCH 2/2] media: i2c: Add OV1063x sensor driver

Hi Laurent,

On 04/01/2021 07:39, Laurent Pinchart wrote:

Add a new V4L2 subdev driver for the OmniVision OV10633 and OV10635
camera sensors. The work is based on the driver from the TI BSP, itself
based on original work by Phil Edworthy posted to the linux-media
mailing list ([1]). This version of the code is a large rewrite of many
parts.

[1] http://www.spinics.net/lists/linux-media/msg64347.html

Signed-off-by: Nikhil Devshatwar <redacted>
Signed-off-by: Benoit Parrot <redacted>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---

<snip>

+static int ov1063x_remove(struct i2c_client *client)
+{
+	struct ov1063x_priv *priv = i2c_get_clientdata(client);

This should be

	struct v4l2_subdev *sd = i2c_get_clientdata(client);
	struct ov1063x_priv *priv = to_ov1063x(sd);

Let me guess, you never tried as a module? ;)

 Tomi