Re: [PATCH 2/2] media: i2c: Add OV1063x sensor driver

On Mon, Jan 04, 2021 at 03:05:05PM +0200, Laurent Pinchart wrote:

Hi Sakari,

On Mon, Jan 04, 2021 at 02:47:00PM +0200, Sakari Ailus wrote:

quoted

Hi Laurent,

On Mon, Jan 04, 2021 at 07:39:45AM +0200, Laurent Pinchart wrote:

quoted

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 878f66ef2719..84a97989775e 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig

@@ -1050,6 +1050,18 @@ config VIDEO_OV9650
 	  This is a V4L2 sensor driver for the Omnivision
 	  OV9650 and OV9652 camera sensors.
 
+config VIDEO_OV10633
+	tristate "OmniVision OV10633/OV10635 sensor support"
+	depends on I2C && VIDEO_V4L2
+	depends on GPIOLIB && OF
+	select MEDIA_CONTROLLER
+	select REGMAP_I2C

Should this be SCCB instead?

Likewise for the driver.

The OV1063x has 16-bit register addresses, and, unless I'm mistaken,
regmap_sccb assumes register addresses to be 8-bit long.

It seems so. I wonder what's the meaning of SCCB in this case. A number of
drivers (three) require REGMAP_SCCB instead of REGMAP_I2C. Could it just be
someone needed those drivers on controllers with just SMBUS functionality?

I guess this is fine then.

-- 
Sakari Ailus