Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

Em 26-06-2012 13:40, Ezequiel Garcia escreveu:

Mauro,

On Mon, Jun 25, 2012 at 5:53 PM, Mauro Carvalho Chehab
[off-list ref] wrote:

quoted

Yeah, research is needed ;) As "bttv" is the mother of the I2C code found at
other PCI drivers, as it is one of the oldest implementations, I bet you'll
find this field propagated without usage on some drivers (and probably other
unused fields as well ;) )

I did some research and it looks like this patch series should be broke in two:
- cleanup i2c_rc and i2c unused stuff
- struct i2c_algo_bit_data cleanup (already sent)

Unless there is some problem with the latter, could you pick this patches:
(i.e, the whole series except the i2c_rc part)
  cx25821: Replace struct memcpy with struct assignment
  cx25821: Remove useless struct i2c_algo_bit_data usage
  cx231xx: Replace struct memcpy with struct assignment
  cx231xx: Remove useless struct i2c_algo_bit_data usage
  cx23885: Replace struct memcpy with struct assignment
  cx23885: Remove useless struct i2c_algo_bit_data
  saa7164: Replace struct memcpy with struct assignment
  saa7164: Remove useless struct i2c_algo_bit_data

  I'll fix a new patch series for i2c_rc cleaning.

Hope this is not too much trouble for you.

I prefer if you could re-send them with a proper description why
i2c_rc is needed. Only really really trivial emails may not
have descriptions ;)

Thanks,
Ezequiel.