Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status
From: Ezequiel Garcia <hidden>
Date: 2012-06-25 20:06:10
On Mon, Jun 25, 2012 at 4:49 PM, Mauro Carvalho Chehab [off-list ref] wrote:
If i2c_rc was never initialized, then just remove it. If it is required, then there's a bug somewhere out there on those drivers. IMHO, if the I2C bus doesn't register, any driver that requires I2C bus should return -ENODEV.
Agreed.
It should be noticed that there are a few devices that don't need I2C bus to work: simple video grabber cards that don't have anything on their I2C. There are several of them at bttv, and a few at cx88 and saa7134. Maybe that's the reason why those drivers have a var to indicate if i2c got registered.
Mmm, that would explain mysterious i2c_rc. Anyway, I'm still a *q-bit* unsure about which drivers require i2c to work and which don't. I'm gonna investigate this carefully and send a v2 (probably just to send a v3 later :) Thanks for reviewing, Ezequiel.