on 2021/11/5 19:34, Jan Kara wrote:

On Fri 05-11-21 03:05:44, xuyang2018.jy@fujitsu.com wrote:

quoted

ps:I also increase ltp quotactl coverage to cover quotactl_fd syscall. I
would appreciate it if you could review my ltp quotactl/quotactl_fd patchset
https://patchwork.ozlabs.org/project/ltp/list/?series=269166

 From a quick look the patches look fine. Just one thing I've noticed - you
seem to open "mntpoint/testfile" so that you have 'fd' to pass to
quotactl_fd(). Why don't you just open "mntpoint" directly?

Oh, yes.

At the beginning, I try it but open fails with EISDIR because I use RW 
mode for the file.

mnt_want_write(f.file->f_path.mnt) just need we can write something into 
superblock instead of a rw file. So I can use read-only fd directly.

Will use mntpoint directly.

Thanks.

								Honza