Thread (14 messages) 14 messages, 4 authors, 2021-11-08

Re: [PATCH] quotactl.2: Remove kernel version for Q_XQUOTARM ioctl

From: Jan Kara <jack@suse.cz>
Date: 2021-11-05 11:34:16

On Fri 05-11-21 03:05:44, xuyang2018.jy@fujitsu.com wrote:
ps:I also increase ltp quotactl coverage to cover quotactl_fd syscall. I 
would appreciate it if you could review my ltp quotactl/quotactl_fd patchset
https://patchwork.ozlabs.org/project/ltp/list/?series=269166
From a quick look the patches look fine. Just one thing I've noticed - you
seem to open "mntpoint/testfile" so that you have 'fd' to pass to
quotactl_fd(). Why don't you just open "mntpoint" directly?

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help